Skip to content

fix: move distribution hashes where they belong - #1120

Merged
jkowalleck merged 2 commits into
mainfrom
fix/component-hash-scope
Nov 5, 2023
Merged

fix: move distribution hashes where they belong#1120
jkowalleck merged 2 commits into
mainfrom
fix/component-hash-scope

Conversation

@jkowalleck

@jkowalleck jkowalleck commented Nov 5, 2023

Copy link
Copy Markdown
Member
  • Fixed
    • SBOM results might have the externalReferences[].hashes populated (#1118 via #1120)
      The hashes might have wrongly appeared as components[].hashes before.
  • Misc
    • Raised dependency @cyclonedx/cyclonedx-library@^6.1.0, was @^3||^4||^5||^6 (via #1120)

fixes #1118

Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck jkowalleck added the bug Something isn't working label Nov 5, 2023
@jkowalleck
jkowalleck requested a review from a team as a code owner November 5, 2023 21:53
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck jkowalleck changed the title tests fix: move distribution hashes where they belong Nov 5, 2023
@codacy-production

Copy link
Copy Markdown

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.04% 100.00% (target: 80.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (1485663) 358 306 85.48%
Head commit (2d09bc5) 359 (+1) 307 (+1) 85.52% (+0.04%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1120) 8 8 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

@jkowalleck
jkowalleck merged commit 1967267 into main Nov 5, 2023
@jkowalleck
jkowalleck deleted the fix/component-hash-scope branch November 5, 2023 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] hashes on wrong element

1 participant